Fix failed ios build after second info-plist merge #1083
Conversation
|
Test PASSed. |
| return (() => { | ||
| let manifestPath = this.platformData.configurationFilePath; | ||
|
|
||
| console.log("ANDROID MANIFEST FILE PATH!!!!"); |
There was a problem hiding this comment.
do you need these console.logs
|
Test FAILed. |
| this.replaceFileContent(pbxprojFilePath).wait(); | ||
| }).future<void>()(); | ||
| } | ||
|
|
||
| public interpolateConfigurationFile(configurationFilePath?: string): IFuture<void> { |
There was a problem hiding this comment.
Is there a reason for this function to return a future?
There was a problem hiding this comment.
|
Why there are changes in the Android specific code? Can you document them in the PR description, or separate them in another PR? |
| this.replaceFileName("-Info.plist", path.join(projectRoot, IOSProjectService.IOS_PROJECT_NAME_PLACEHOLDER)).wait(); | ||
| this.replaceFileName("-Prefix.pch", path.join(projectRoot, IOSProjectService.IOS_PROJECT_NAME_PLACEHOLDER)).wait(); | ||
| this.replaceFileName(IOSProjectService.XCODE_PROJECT_EXT_NAME, projectRoot).wait(); | ||
| this.replaceFileName("-Info.plist", path.join(this.platformData.projectRoot, IOSProjectService.IOS_PROJECT_NAME_PLACEHOLDER)).wait(); |
There was a problem hiding this comment.
You can extract this long path into a dedicated variable - it is used on more than one place
|
This is the reason why I need the changes in the Android specific code - https://github.com/NativeScript/nativescript-cli/pull/1083/files#diff-513fe963f5d821a1cdb167ea91d70f1cR105. I cannot separate this in another PR, this change must be here. |
|
Test FAILed. |
Fatme
force-pushed
the
fatme/fix-info-plist-merge
branch
from
b710ba0 to
249576e
Compare
|
Test FAILed. |
Fatme
force-pushed
the
fatme/fix-info-plist-merge
branch
from
249576e to
eb72914
Compare
Fatme
force-pushed
the
fatme/fix-info-plist-merge
branch
from
eb72914 to
2daee31
Compare
|
Test FAILed. |
|
Test PASSed. |
|
👍 |
Fix failed ios build after second info-plist merge
Fixes #1066